Skip to content

Add support for data cache#1932

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
Sneha-at:data-cache-support
Feb 20, 2025
Merged

Add support for data cache#1932
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
Sneha-at:data-cache-support

Conversation

@Sneha-at
Copy link
Copy Markdown
Contributor

@Sneha-at Sneha-at commented Feb 12, 2025 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Adds the required support in PDCSI driver to setup caching for PVCs using local SSDs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add GKE only data cache feature support in PDCSI driver, it allows to set up LSSDs as caching layer for created PVCs.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2025
@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 12, 2025

/test all

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 12, 2025
sunnylovestiramisu
sunnylovestiramisu reviewed Feb 13, 2025
View reviewed changes
Comment thread Dockerfile
sunnylovestiramisu
sunnylovestiramisu reviewed Feb 13, 2025
View reviewed changes
Comment thread cmd/gce-pd-csi-driver/main.go Outdated
sunnylovestiramisu
sunnylovestiramisu reviewed Feb 13, 2025
View reviewed changes
Comment thread cmd/gce-pd-csi-driver/main.go
@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 13, 2025

/test all

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 13, 2025

/test all

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 13, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

1 similar comment
@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 13, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 14, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 14, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 17, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 17, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

1 similar comment
@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 17, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 17, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 17, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 19, 2025
@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 19, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Feb 20, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Copy Markdown
Contributor Author

Sneha-at commented Feb 20, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-unit

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Feb 20, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sneha-at, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Feb 20, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Feb 20, 2025

Closed with the wrong button, sorry.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Feb 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6bb2719 into kubernetes-sigs:master Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 25, 2025
@darkweaver87 darkweaver87 mentioned this pull request Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@amacaskill amacaskill Awaiting requested review from amacaskill

@mattcary mattcary Awaiting requested review from mattcary

@leiyiz leiyiz Awaiting requested review from leiyiz

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sneha-at @k8s-ci-robot @sunnylovestiramisu